Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@remicollet , I'll see about getting a release out today or tomorrow. The server-side PEAR channel file will be the only one I might be able to update myself, so do you have contacts to handle the DOC and PECL ones, before this release goes out wide?

@remicollet , build failures since merging this seem to be testcases that expected http-before-https behavior. I've fixed some of them, but can't figure out the others... though I'm suspecting they're due to the PECL site needing its channel file adjusted like I did the PEAR channel file, as the error output is generally some variation on this:

No REST config for URL https://pecl.php.net/rest/r/pecl_http/allreleases.xml

I'm hoping you do know a PECL contact that can update its channel file... I'll pause on rolling a release until that can happen, allowing me to then verify if that resolves these still-failing testcases.

I'm hoping you do know a PECL contact that can update its channel file...

Perhaps @derickr can help

@ashnazg it seems to be a test issue

Can you please try with

diff --git a/tests/PEAR_test_mock_pearweb.php.inc b/tests/PEAR_test_mock_pearweb.php.inc
index f7b16a15..29d1e417 100644
--- a/tests/PEAR_test_mock_pearweb.php.inc
+++ b/tests/PEAR_test_mock_pearweb.php.inc
@@ -89,8 +89,7 @@ class PEAR_test_mock_pearweb
             if (!$ret) {
                 echo '$pearweb->addRESTConfig("' . $address . "\", true, 'text/xml');\n";
             } else {
-                echo '$pearweb->addRESTConfig("' . $address . '", ' . var_export($ret[0], true)
-                    . ", 'text/xml');\n";
+                $this->_continue = true;
             }
             return $ret;
         } else {

Most tests pass (have some local issues, not related to this, because not running test as root...)

I don't understand why PECL needs changing, as it only lists https in its channel file?

@derickr I think the PECL website is OK, only tests are broken as written when HTTP was the default

Released in v1.10.17.